show auto-complete hints for tag based search in haystack search bar#261
show auto-complete hints for tag based search in haystack search bar#261doctorXWrites wants to merge 12 commits intomasterfrom
Conversation
|
show values of what? |
|
@adriancole I just created an issue to document the feature. The problem was that whenever we try searching using tags(if traces are indexed by the given tag) there are no auto-populate hints as in dropdown. This PR is to allow the required data to be indexed and stored which would be used to support this feature. |
|
makes sense, we have the same feature and same concerns. because elasticsearch is so easy to overload, we also have a limiter as writing same tag many times increases index pressure https://github.com/openzipkin/zipkin/tree/master/zipkin-storage/elasticsearch#autocomplete-indexing |
We handle this by flushing the documents to ES at a regular interval (configurable). This handles duplicate documents and reduce the indexing pressure. Do note that tags(or what we call as whitelisted index fields) having 'showValues' enabled, goes into a different ES index for this autocomplete feature. |
|
thanks for sharing!
…On Wed, Aug 14, 2019 at 1:51 PM Ashish Aggarwal ***@***.***> wrote:
makes sense, we have the same feature and same concerns. because
elasticsearch is so easy to overload, we also have a limiter as writing
same tag many times increases index pressure
https://github.com/openzipkin/zipkin/tree/master/zipkin-storage/elasticsearch#autocomplete-indexing
We handle this by flushing the document to ES at a regular interval
(configurable). This handles duplicate documents and reduce the indexing
pressure. Do note that tags(or what we call as whitelisted index fields)
having 'showValues' enabled, goes into a different ES index for this
autocomplete feature.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#261?email_source=notifications&email_token=AAAPVV3UB2YQXIEOF2IPTJDQEOMOJA5CNFSM4ILHLAQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4HYLLA#issuecomment-521110956>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAPVV6TBRLJ5EGQW3JZOFDQEOMOJANCNFSM4ILHLAQA>
.
|
No description provided.