Set auto-gen span's service name to "unknown"#167
Open
chrismikehogan wants to merge 1 commit intoExpediaDotCom:masterfrom
Open
Set auto-gen span's service name to "unknown"#167chrismikehogan wants to merge 1 commit intoExpediaDotCom:masterfrom
chrismikehogan wants to merge 1 commit intoExpediaDotCom:masterfrom
Conversation
When a trace is missing a span, we dont know what service is missing, so it is less confusing if we label the service as "unknown" rather than guessing (often incorrectly) that the service's name isthe same as the child span's service name.
Member
|
@chrismikehogan This function is used in two cases
so if you update the code to take in an optional autogenerated root span, service name else use the current behaviour, this pr should be good to merge |
Member
|
Also you would need to fix the test cases :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a trace is missing a span, we dont know what service is missing, so it is less confusing if we label the service as "unknown" rather than guessing (often incorrectly) that the service's name isthe same as the child span's service name.