Open
Conversation
HeahDude
requested changes
Apr 18, 2022
Collaborator
HeahDude
left a comment
HeahDude
left a comment
There was a problem hiding this comment.
Hello @ottaviano :) Thank you for this PR and sorry for the delay. Are you still interested in finishing this?
| $loader->load('html_purifier.xml'); | ||
|
|
||
| $configs = $this->processConfiguration(new Configuration(), $configs); | ||
| $configs = array_map([$this, 'resolveServices'], $configs); |
Collaborator
There was a problem hiding this comment.
Suggested change
| $configs = array_map([$this, 'resolveServices'], $configs); | |
| $configs = $container->resolveServices($configs); |
Author
There was a problem hiding this comment.
Hello @HeahDude, the test no longer passes with this solution, @App\MyService is not replaced by Reference instance
Collaborator
There was a problem hiding this comment.
Alright then we need to be more careful with possible conflict and allow escaping @ when it's expected as legit character.
I propose to use a regex instead and allow escaping by doubling @@ as it is done in yaml config in Symfony.
We should also add a note about it in the docs (in the README).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
I copied this piece of code from v1.0.0 of the bundle to keep the possibility of using Sf service in the bundle config: