Skip to content

fix: AdminToy.Position & Rotation ignoring parenting#687

Merged
louis1706 merged 1 commit intoExMod-Team:devfrom
Banalny-Banan:fix-toys
Mar 16, 2026
Merged

fix: AdminToy.Position & Rotation ignoring parenting#687
louis1706 merged 1 commit intoExMod-Team:devfrom
Banalny-Banan:fix-toys

Conversation

@Banalny-Banan
Copy link
Copy Markdown

@Banalny-Banan Banalny-Banan commented Nov 22, 2025

Description

Describe the changes
NetworkPosition and NetworkRotation syncvars control local position/rotation, but Exiled AdminToy's properties were assigning global values to them.


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link
Copy Markdown

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would approve it but i want Nameless to thinks if that could cause any breaking plugin ?

Copy link
Copy Markdown
Member

@obvEve obvEve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plugin that depends on this not being the case, would have their intended behavior break - other than that LGTM

Copy link
Copy Markdown

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am thinking instead of these making a LocalPosition and LocalRotation

@louis1706 louis1706 merged commit 0b968a7 into ExMod-Team:dev Mar 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants