fix(docker): remove invalid must-revalidate parameter from gzip_proxied#24
Open
Oraculo-sh wants to merge 1 commit intoEvolutionAPI:mainfrom
Open
fix(docker): remove invalid must-revalidate parameter from gzip_proxied#24Oraculo-sh wants to merge 1 commit intoEvolutionAPI:mainfrom
Oraculo-sh wants to merge 1 commit intoEvolutionAPI:mainfrom
Conversation
The Nginx container was trapped in a crash loop during boot because 'must-revalidate' is an invalid parameter for the 'gzip_proxied' directive in .docker/nginx.conf. Removed the parameter to restore stability.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves an invalid Sequence diagram for container startup before and after gzip_proxied fixsequenceDiagram
participant Dev as developer
participant DC as docker_compose
participant C as evolution_frontend_container
participant N as nginx
participant Conf as nginx_conf
Dev->>DC: run docker compose up
DC->>C: create and start container
C->>N: start nginx master process
N->>Conf: load /etc/nginx/conf.d/nginx.conf
alt config_before_fix
Conf-->>N: directive gzip_proxied ... must_revalidate auth
N-->>C: [emerg] invalid value must-revalidate
C-->>DC: exit with status 1
else config_after_fix
Conf-->>N: directive gzip_proxied ... auth
N-->>C: configuration ok
C-->>DC: container status Up
end
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📋 Description
This PR fixes a critical crash loop in the Nginx container during the boot process. The error was caused by the presence of the
must-revalidateparameter within thegzip_proxieddirective in the.docker/nginx.conffile.While
must-revalidateis a valid string forCache-Controlheaders, it is not a valid parameter forgzip_proxied. Recent versions of the Nginx engine (specifically mainline 1.26+) have moved from issuing warnings to fatal errors when encountering invalid parameters in this directive, leading to an immediate container crash ([emerg]).🔗 Related Issues
🧪 Type of Change
🧪 Testing
Test Environment
Test Cases
Test Instructions
docker compose up.evolution_frontendcontainer log; it will fail withnginx: [emerg] invalid value "must-revalidate" in /etc/nginx/conf.d/nginx.conf:11.must-revalidatefrom thegzip_proxiedline in.docker/nginx.conf.Upand worker processes have started.✅ Checklist
Code Quality
npm run lintand fixed any issuesTesting
Thank you for contributing to Evolution Manager! 🚀
Summary by Sourcery
Bug Fixes: