feat: add project-standards-reviewer as always-on ce:review persona#402
Merged
feat: add project-standards-reviewer as always-on ce:review persona#402
Conversation
Adds a new always-on reviewer that audits diffs against the project's own CLAUDE.md and AGENTS.md standards -- frontmatter rules, reference inclusion, naming conventions, cross-platform portability, and tool selection policies. Inspired by Anthropic's code-review command pattern where CLAUDE.md compliance is a first-class review lens. The orchestrator discovers standards file paths via glob and passes them to the reviewer, which reads only the sections relevant to the changed file types. Also documents the "pass paths, not content" orchestration pattern as a learning in docs/solutions/ and a best practice in AGENTS.md.
Empirical testing showed "find all X, then filter" produces 2 tool calls vs "for each item, walk and check" producing 14 in Claude Code. The right fix is writing the correct instruction in the skill itself, not adding meta-rules to AGENTS.md about how to phrase instructions.
When in doubt about instruction phrasing efficiency, test with claude -p and codex exec to compare tool call counts across platforms before committing to a phrasing in high-frequency skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project-standards-revieweras a new always-on persona in ce:review that audits diffs against the project's own CLAUDE.md and AGENTS.md standards (frontmatter, reference inclusion, naming, cross-platform portability, tool selection)Test plan
bun testpasses (496 tests, 0 failures)bun run release:validateshows metadata in sync (45 agents, 42 skills)/ce:reviewon a branch with skill/agent changes and confirmproject-standardsappears in the reviewer team and produces findings/ce:reviewon a branch with only TypeScript changes and confirmproject-standardsruns but produces no findings (rules don't apply to those file types)