fix: retry safe memory reads without retrying writes#5
Draft
viowai wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the agent SDK's unreachable transport retry path and make retry eligibility depend on explicit request semantics rather than HTTP method alone. Preserve redacted structured diagnostics through the generic MCP adapter while keeping all memory writes single-attempt.
Changes
safe_readandnon_idempotent_writerequest semantics with a hard allowlist for POST/mem/searchand/mem/context.Retry-Afteronly when it fits that budget.EvermeErrorfields for classification, cause code, HTTP status, request id, attempts, retryability, and elapsed time.structuredContent.errorwhile preserving the existingisErrortext response.Test Plan
cli/is unchanged)npm test --workspaces --if-presentnpm audit --audit-level=moderatereports 0 vulnerabilitiesSecurity
emk_*,evt_*, cookies, private URLs, production logs, memory queries, or request bodies are includedRelated Issues
Release Note
The code change is backward-compatible and does not bump package versions in this PR. A maintainer release of aligned
@everme/agent-sdkand@everme/memory-mcppackages is still required before downstream hosts can pin the fix and remove temporary host-side guards.