refactor dynamic tables to accept initial data as props for improved data handling

[vLuckyyy]

No description provided.

[netlify]

✅ Deploy Preview for eternalcodeteam-website ready!

Name	Link
🔨 Latest commit	e257d1c
🔍 Latest deploy log	https://app.netlify.com/projects/eternalcodeteam-website/deploys/697792cf542cd900081b13e9
😎 Deploy Preview	https://deploy-preview-216--eternalcodeteam-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 50 (🔴 down 26 from production) Accessibility: 94 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[gemini-code-assist]

Summary of Changes

Hello @vLuckyyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the data fetching architecture for the dynamic tables displaying EternalCore commands and placeholders. By migrating data retrieval from client-side hooks to dedicated React Server Components, the application can now pre-fetch and hydrate these components on the server. This change is designed to enhance the user experience by improving initial page load performance and reducing the client's workload, making the tables more efficient and responsive.

Highlights

• React Server Components (RSC) Integration: Introduced new React Server Components (RSCs) for fetching data for both commands and placeholders. These RSCs (CommandsTableRSC and PlaceholdersTableRSC) now handle the initial data retrieval on the server.
• Centralized Data Fetching: A new utility file (lib/docs/eternalcore-data.ts) has been added to centralize the server-side fetching and processing of EternalCore command and placeholder data, including Next.js revalidation and caching tags.
• Client-Side Optimization: The DynamicCommandsTable and DynamicPlaceholdersTable components, along with their respective useCommands and usePlaceholders hooks, have been refactored to accept initialData as a prop. This removes client-side data fetching, improving initial load performance and reducing client-side bundle size.
• MDX Components Update: The mdx-components.tsx file has been updated to utilize the new RSCs for rendering the dynamic tables and now dynamically imports the LinkPreview component for further optimization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the dynamic tables for commands and placeholders to fetch data on the server using React Server Components (RSCs), passing the data as props to client components. This is an excellent architectural improvement that leverages modern Next.js features to enhance performance by shifting data fetching from the client to the server. The implementation is well-executed across all modified files. My review includes a couple of suggestions for the new data fetching logic in lib/docs/eternalcore-data.ts to improve type safety and code clarity.

[gemini-code-assist]

The explicit type annotation for the b parameter is redundant. If the placeholders array is properly typed (which would be the case after addressing the any[] cast on line 72), TypeScript can correctly infer the types of both a and b from the array. Removing the explicit type makes the code cleaner and more maintainable.

  const sortedPlaceholders = placeholders.sort((a, b) =>
    a.name.localeCompare(b.name)
  );