GH-331 Add pearl stasis prevention feature

[igoyek]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @igoyek, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances combat mechanics by addressing an exploit where players could use Ender Pearl stasis to disengage from combat. It introduces a configurable option to prevent such teleports for players actively engaged in a fight, ensuring more consistent combat encounters. Additionally, a minor update to the Minecraft development version was included.

Highlights

• New Feature: Pearl Stasis Prevention: Introduced a new feature to prevent players from using Ender Pearl stasis to escape combat. When enabled, players in combat will have their Ender Pearl teleports cancelled.
• Configuration Option: Added a new boolean setting preventPearlStasis to FightPearlSettings which controls whether the pearl stasis prevention feature is active.
• Minecraft Version Update: The development environment's Minecraft version was updated from 1.21.10 to 1.21.11 in the build.gradle.kts file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a feature to prevent ender pearl stasis during combat. The implementation is clean, adding a new configuration option and an event handler for PlayerTeleportEvent. My main feedback is to add a notification to the player when their teleportation is cancelled to improve user experience. I've added specific suggestions for this in the code.

[gemini-code-assist]

It's good practice to provide feedback to the player when an action is blocked. Consider adding a configurable message for when pearl stasis is prevented. This message can then be used in FightPearlController to inform the player why their teleport was cancelled.

Suggested change

	public boolean preventPearlStasis = false;
	public boolean preventPearlStasis = false;
	@Comment("# Message sent when a player's ender pearl teleport is cancelled during combat")
	public Notice pearlTeleportBlockedDuringCombat = BukkitNotice.builder()
	.chat("<red>You cannot teleport with an ender pearl while in combat!>")
	.build();

[gemini-code-assist]

To improve user experience, you should notify the player why their teleportation was cancelled. This provides clear feedback and avoids confusion. This change assumes you've added a corresponding pearlTeleportBlockedDuringCombat notice in FightPearlSettings as suggested in my other comment.

        event.setCancelled(true);

        this.noticeService.create()
            .player(event.getPlayer())
            .notice(this.settings.pearlTeleportBlockedDuringCombat)
            .send();

[CitralFlo]

You are blocking not only stasis teleports but also using normal pearls - ex. teleporting closer to the opponent during fight