Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
3fa5bfa
I've added new options to Pearl and Trident that reset the timer when…
Pawelusze Dec 14, 2025
fa7e220
I made the corrections that gemini noticed
Pawelusze Dec 14, 2025
e48a01f
The improvements suggested by the team have been implemented
Pawelusze Dec 29, 2025
f4bdbb7
Implemented suggestions from the team
Pawelusze Dec 29, 2025
51d4e34
Bump packetevents version to support future MC versions
Jakubk15 Dec 29, 2025
2e899de
Make tridents throw check work on all tridents, regardless of enchant…
Jakubk15 Dec 29, 2025
0be6867
Merge remote-tracking branch 'origin/feature/add-reset-timer' into fe…
Pawelusze Jan 4, 2026
ab4e804
Implemented suggestions from the team and fixed `FightTridentControll…
Pawelusze Feb 2, 2026
5ec350a
Corrected comments and field names
Pawelusze Feb 3, 2026
ee6cac5
Implemented CitralFlo suggestions
Pawelusze Feb 4, 2026
68fb2ef
Implemented CitralFlo suggestions again
Pawelusze Feb 5, 2026
5efe39b
Merge branch 'master' into feature/add-reset-timer
CitralFlo Feb 6, 2026
0841c22
Follow igoyek's review from 21.10.25
CitralFlo Feb 6, 2026
76e84ab
CR
Rollczi Feb 7, 2026
07ab306
Simplify naming - extract logic to service for Pearls
CitralFlo Feb 7, 2026
795c7b6
make it more logical
CitralFlo Feb 7, 2026
984449b
Refactor trident-related classes and services for improved clarity an…
CitralFlo Feb 7, 2026
3b0bd15
Rename trident cooldown methods to improve clarity and update comment…
CitralFlo Feb 7, 2026
486789d
Fixes after tests - everything should be working now!
CitralFlo Feb 8, 2026
70b3c7b
Remove commented line
CitralFlo Feb 8, 2026
996e95c
Add cooldown to enderpearl - hack by:https://www.spigotmc.org/threads…
CitralFlo Feb 8, 2026
3b19294
Bump minecraft version in runServer task to 1.21.11
Jakubk15 Feb 8, 2026
c7588e5
Add combat restrictions for Riptide tridents and improve event handling
vLuckyyy Mar 5, 2026
70f6a5f
Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…
Jakubk15 Mar 7, 2026
1bdeaf6
Apply suggestion from @Jakubk15
Jakubk15 Mar 7, 2026
20ab95a
Merge branch 'master' into feature/add-reset-timer
Jakubk15 Mar 7, 2026
3f8b624
Merge remote-tracking branch 'refs/remotes/upstream/master' into feat…
Jakubk15 Mar 7, 2026
4a8cf17
Migrate to commons delay
Jakubk15 Mar 7, 2026
a3b1a33
Merge branch 'master' into feature/add-reset-timer
Jakubk15 Mar 8, 2026
2a8b17b
Merge branch 'master' into feature/add-reset-timer
Jakubk15 Mar 8, 2026
9f4a715
Merge remote-tracking branch 'origin/feature/add-reset-timer' into fe…
Jakubk15 Mar 8, 2026
38cc29e
Resolve conflicts
Jakubk15 Mar 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.eternalcode.combat.fight.trident;

import java.time.Duration;
import java.time.Instant;
import java.util.UUID;

public interface FightTridentService {

Instant getDelay(UUID uuid);

Duration getRemainingDelay(UUID uuid);

boolean hasDelay(UUID uuid);

void markDelay(UUID uuid);
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
import com.eternalcode.combat.fight.knockback.KnockbackService;
import com.eternalcode.combat.fight.tagout.FightTagOutService;
import com.eternalcode.combat.fight.pearl.FightPearlService;
import com.eternalcode.combat.fight.trident.FightTridentController;
import com.eternalcode.combat.fight.trident.FightTridentService;
import com.eternalcode.combat.fight.trident.FightTridentServiceImpl;
import com.eternalcode.combat.handler.InvalidUsageHandlerImpl;
import com.eternalcode.combat.handler.MissingPermissionHandlerImpl;
import com.eternalcode.combat.config.ConfigService;
Expand Down Expand Up @@ -78,6 +81,7 @@ public final class CombatPlugin extends JavaPlugin implements EternalCombatApi {

private FightManager fightManager;
private FightPearlService fightPearlService;
private FightTridentService fightTridentService;
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
private FightTagOutService fightTagOutService;
private FightEffectService fightEffectService;

Expand Down Expand Up @@ -106,6 +110,7 @@ public void onEnable() {

this.fightManager = new FightManagerImpl(eventManager);
this.fightPearlService = new FightPearlServiceImpl(pluginConfig.pearl);
this.fightTridentService = new FightTridentServiceImpl(pluginConfig.trident);
this.fightTagOutService = new FightTagOutServiceImpl();
this.fightEffectService = new FightEffectServiceImpl();

Expand Down Expand Up @@ -173,7 +178,8 @@ public void onEnable() {
new FightTagController(this.fightManager, pluginConfig),
new FightUnTagController(this.fightManager, pluginConfig, logoutService),
new FightActionBlockerController(this.fightManager, noticeService, pluginConfig, server),
new FightPearlController(pluginConfig.pearl, noticeService, this.fightManager, this.fightPearlService),
new FightPearlController(pluginConfig.pearl, noticeService, this.fightManager, this.fightPearlService, pluginConfig),
new FightTridentController(pluginConfig.trident, noticeService, this.fightManager, this.fightTridentService, pluginConfig),
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
new UpdaterNotificationController(updaterService, pluginConfig, this.audienceProvider, miniMessage),
new KnockbackRegionController(noticeService, this.regionProvider, this.fightManager, knockbackService, server),
new FightEffectController(pluginConfig.effect, this.fightEffectService, this.fightManager, this.getServer()),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import com.eternalcode.combat.fight.effect.FightEffectSettings;
import com.eternalcode.combat.fight.knockback.KnockbackSettings;
import com.eternalcode.combat.fight.pearl.FightPearlSettings;
import com.eternalcode.combat.fight.trident.FightTridentSettings;
import eu.okaeri.configs.OkaeriConfig;
import eu.okaeri.configs.annotation.Comment;
import java.time.Duration;
Expand Down Expand Up @@ -35,6 +36,13 @@ public class PluginConfig extends OkaeriConfig {
})
public FightPearlSettings pearl = new FightPearlSettings();

@Comment({
" ",
"# Settings related to Trident",
"# Configure cooldowns, restrictions, and other behaviors for Trident during combat."
})
public FightTridentSettings trident = new FightTridentSettings();

@Comment({
" ",
"# Custom effects applied during combat.",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.eternalcode.combat.fight.pearl;

import com.eternalcode.combat.config.implementation.PluginConfig;
import com.eternalcode.combat.fight.FightManager;
import com.eternalcode.combat.fight.event.CauseOfTag;
import com.eternalcode.combat.notification.NoticeService;
import com.eternalcode.combat.util.DurationUtil;
import java.time.Duration;
Expand All @@ -14,25 +16,27 @@
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.ProjectileLaunchEvent;
import org.bukkit.inventory.ItemStack;

public class FightPearlController implements Listener {

private final FightPearlSettings settings;
private final NoticeService noticeService;
private final FightManager fightManager;
private final FightPearlService fightPearlService;
private final PluginConfig config;

public FightPearlController(
FightPearlSettings settings,
NoticeService noticeService,
FightManager fightManager,
FightPearlService fightPearlService
FightPearlService fightPearlService,
PluginConfig config
) {
this.settings = settings;
this.noticeService = noticeService;
this.fightManager = fightManager;
this.fightPearlService = fightPearlService;
this.config = config;
}

@EventHandler(priority = EventPriority.HIGHEST)
Expand Down Expand Up @@ -63,6 +67,11 @@ public void onPearlThrow(ProjectileLaunchEvent event) {
if (this.settings.pearlCooldownEnabled) {
handlePearlCooldown(event, player, playerId);
}

if (this.settings.pearlResetsTimerEnabled) {
Duration combatTime = this.config.settings.combatTimerDuration;
this.fightManager.tag(playerId, combatTime, CauseOfTag.CUSTOM);
Comment thread
Jakubk15 marked this conversation as resolved.
Outdated
}
}

@EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ public class FightPearlSettings extends OkaeriConfig {
@Comment("# Set true, If you want add cooldown to pearls")
public boolean pearlCooldownEnabled = false;

@Comment("# Set true, If you want to reset timer when player throws ender pearl")
public boolean pearlResetsTimerEnabled = true;
Comment thread
CitralFlo marked this conversation as resolved.
Outdated

@Comment({
"# Block throwing pearls with delay?",
"# If you set this to for example 3s, player will have to wait 3 seconds before throwing another pearl"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
package com.eternalcode.combat.fight.trident;

import com.eternalcode.combat.config.implementation.PluginConfig;
import com.eternalcode.combat.fight.FightManager;

import com.eternalcode.combat.fight.event.CauseOfTag;
import com.eternalcode.combat.notification.NoticeService;
import com.eternalcode.combat.util.DurationUtil;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;

import java.time.Duration;
import java.util.UUID;

public class FightTridentController implements Listener {
Comment thread
Jakubk15 marked this conversation as resolved.
Outdated

private final FightTridentSettings settings;
private final NoticeService noticeService;
private final FightManager fightManager;
private final FightTridentService fightTridentService;
private final PluginConfig config;

public FightTridentController(
FightTridentSettings settings,
NoticeService noticeService,
FightManager fightManager,
FightTridentService fightTridentService,
PluginConfig config
) {
this.settings = settings;
this.noticeService = noticeService;
this.fightManager = fightManager;
this.fightTridentService = fightTridentService;
this.config = config;
}


@EventHandler(priority = EventPriority.HIGHEST)
public void onTridentInteract(PlayerInteractEvent event) {
ItemStack item = event.getItem();

if (item == null || item.getType() != Material.TRIDENT) {
return;
}

Player player = event.getPlayer();
UUID playerId = player.getUniqueId();

if (!this.fightManager.isInCombat(playerId)) {
return;
}

if (this.settings.tridentThrowDisabledDuringCombat) {
event.setCancelled(true);
this.noticeService.create()
.player(playerId)
.notice(this.settings.tridentThrowBlockedDuringCombat)
.send();
return;
}

if (this.settings.tridentCooldownEnabled) {
this.handleTridentCooldown(event, player, playerId);
}

if (this.settings.tridentResetsTimerEnabled) {
Duration combatTime = this.config.settings.combatTimerDuration;
this.fightManager.tag(playerId, combatTime, CauseOfTag.CUSTOM);
}
}

private void handleTridentCooldown(PlayerInteractEvent event, Player player, UUID playerId) {
if (this.settings.tridentThrowDelay.isZero()) {
return;
}

if (this.fightTridentService.hasDelay(playerId)) {
event.setCancelled(true);
Duration remainingDelay = this.fightTridentService.getRemainingDelay(playerId);

this.noticeService.create()
.player(playerId)
.notice(this.settings.tridentThrowBlockedDelayDuringCombat)
.placeholder("{TIME}", DurationUtil.format(remainingDelay))
.send();
return;
}

this.fightTridentService.markDelay(playerId);
int cooldownTicks = (int) (this.settings.tridentThrowDelay.toMillis() / 50);
player.setCooldown(Material.TRIDENT, cooldownTicks);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package com.eternalcode.combat.fight.trident;

import com.github.benmanes.caffeine.cache.Cache;
import com.github.benmanes.caffeine.cache.Caffeine;

import java.time.Duration;
import java.time.Instant;
import java.util.UUID;

public class FightTridentServiceImpl implements FightTridentService {
private final FightTridentSettings tridentSettings;
private final Cache<UUID, Instant> tridentStartTimes;

public FightTridentServiceImpl(FightTridentSettings pearlSettings) {
this.tridentSettings = pearlSettings;
Comment thread
Jakubk15 marked this conversation as resolved.
Outdated
this.tridentStartTimes = Caffeine.newBuilder()
.expireAfterWrite(pearlSettings.tridentThrowDelay)
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
.build();
}

@Override
public void markDelay(UUID uuid) {
this.tridentStartTimes.put(uuid, Instant.now());
}

@Override
public boolean hasDelay(UUID uuid) {
return this.tridentStartTimes.getIfPresent(uuid) != null;
}

@Override
public Duration getRemainingDelay(UUID uuid) {
Instant startTime = this.tridentStartTimes.getIfPresent(uuid);
if (startTime == null) {
return Duration.ZERO;
}

Duration elapsed = Duration.between(startTime, Instant.now());
Duration remaining = this.tridentSettings.tridentThrowDelay.minus(elapsed);

return remaining.isNegative() ? Duration.ZERO : remaining;
}

@Override
public Instant getDelay(UUID uuid) {
Instant startTime = this.tridentStartTimes.getIfPresent(uuid);
return startTime != null ? startTime.plus(this.tridentSettings.tridentThrowDelay) : Instant.MIN;
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package com.eternalcode.combat.fight.trident;

import com.eternalcode.multification.bukkit.notice.BukkitNotice;
import com.eternalcode.multification.notice.Notice;
import eu.okaeri.configs.OkaeriConfig;
import eu.okaeri.configs.annotation.Comment;

import java.time.Duration;

public class FightTridentSettings extends OkaeriConfig {

@Comment({
"# Set true, If you want to disable throwing trident during combat",
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
"# This will work globally, but can be overridden by region settings"
})
public boolean tridentThrowDisabledDuringCombat = true;
Comment thread
CitralFlo marked this conversation as resolved.
Outdated

@Comment("# Set true, If you want add cooldown to trident")
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
public boolean tridentCooldownEnabled = false;

@Comment("# Set true, If you want to reset timer when player uses trident")
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
public boolean tridentResetsTimerEnabled = true;
Comment thread
CitralFlo marked this conversation as resolved.
Outdated

@Comment({
"# Block throwing trident with delay?",
"# If you set this to for example 3s, player will have to wait 3 seconds before throwing trident"
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
})
public Duration tridentThrowDelay = Duration.ofSeconds(3);

@Comment("# Message sent when player tries to throw trident, but are disabled")
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
public Notice tridentThrowBlockedDuringCombat = BukkitNotice.builder()
.chat("<red>Throwing trident is prohibited during combat!")
.build();

@Comment("# Message sent when player tries to throw trident, but has delay")
Comment thread
CitralFlo marked this conversation as resolved.
Outdated
public Notice tridentThrowBlockedDelayDuringCombat = BukkitNotice.builder()
.chat("<red>You must wait {TIME} before next throw!")
.build();
}
Loading