Add CI job to force WORKSPACE usage - #258
Open
furtib wants to merge 1 commit into
Open
Conversation
Collaborator
|
Why don't we enable this for bazel 8? I thought workspace will only be disabled by bazel 9. Or shall we declare that we only support workspace before bazel 8? |
Szelethus
reviewed
Jul 28, 2026
Comment on lines
+44
to
+51
| - bazel_version: "7.7.1" | ||
| bazel_mode: "workspace" | ||
|
|
||
| - bazel_version: "7.7.1" | ||
| bazel_mode: "module" | ||
|
|
||
| - bazel_version: "8.5.1" | ||
| bazel_mode: "module" |
Collaborator
There was a problem hiding this comment.
This looks trivial from in the context of the PR, but lets rationalize this with a few comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We currently have no CI workflow using our workspace file.
Since Bazel 7 (the last version that) supports WORKSPACE files, we should test it working with just the workspace file too, not just with the MODULE.bazel file.
What:
Addresses:
none