Add test for metadata - #254
Open
furtib wants to merge 4 commits into
Open
Conversation
furtib
force-pushed
the
metadata-test
branch
4 times, most recently
from
June 30, 2026 08:54
b88bc48 to
6f62e93
Compare
Szelethus
requested changes
Jul 1, 2026
| unit_test( | ||
| name = "per_file_metadata_test", | ||
| data = [":per_file_multiple_source"], | ||
| excludes = [r"\"action_num\": 2,"], |
Collaborator
There was a problem hiding this comment.
I suppose this is the important bit, no? That this should be contains instead.
Contributor
Author
There was a problem hiding this comment.
Great catch, fixed it!
Szelethus
reviewed
Jul 5, 2026
Comment on lines
+67
to
+68
| # FIXME: remove when metadata is generated | ||
| tags = ["manual"], |
Collaborator
There was a problem hiding this comment.
As is, I don't think this is a great precursor patch. We could check whether this (these?) files exists at all, AND THEN check how merging works.
Contributor
Author
There was a problem hiding this comment.
There is currently no way to check if a file is missing.
If no input file is found the test just fails.
Contributor
Author
There was a problem hiding this comment.
I tried to make a way to assert files existing #261.
Using that, we could assert the existence of individual metadata files, but not the merged one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to test metadata contents before merging #79.
What:
Addresses:
#45