Use py_binary with constants file, instead of arguments - #253
Open
furtib wants to merge 4 commits into
Open
Conversation
furtib
changed the title
furtib
force-pushed
the
py-bin-per-file
branch
2 times, most recently
from
July 4, 2026 16:40
a63caf3 to
fc5b580
Compare
furtib
marked this pull request as ready for review
July 4, 2026 16:40
Contributor
Author
|
It seems for this to work I will have rewrite the plist resolution test as a bazel py_test target, which depend on the py_binary from src. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
I want to create a more organized, easily understandable alternative to #199.
The goal is to choose one of these two.
Since there is a limit on the length of the arguments we can pass to our scripts, and passing many arguments makes things complicated, I decided to replace
expand_templatewith abazel_constants.jsonfile.This way, we can pass any number of arguments in an organized manner to the Python script.
What:
Addresses:
none