Convert unit tests into the new unit_test macro - #248
Open
furtib wants to merge 6 commits into
Open
Conversation
furtib
force-pushed
the
test_into_bazel_002
branch
3 times, most recently
from
June 18, 2026 14:54
580a3b3 to
2766f71
Compare
furtib
force-pushed
the
test_into_bazel_002
branch
from
June 27, 2026 07:19
2766f71 to
ba3a54c
Compare
furtib
changed the title
furtib
marked this pull request as ready for review
June 30, 2026 08:06
furtib
force-pushed
the
test_into_bazel_002
branch
from
June 30, 2026 08:07
079dc29 to
b9ecaf0
Compare
Szelethus
reviewed
Jul 5, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
I haven't read the PR in its entirety, just a preliminary comment.
| all_files = [compile_commands] | ||
| config_file, env_vars = get_config_file(ctx) | ||
| _create_wrapper_script(ctx, options, compile_commands, config_file) | ||
| all_files = [compile_commands, config_file] |
Collaborator
There was a problem hiding this comment.
Considering the nature of this PR, it would be amazing to land this separately and make this NFC.
Contributor
Author
There was a problem hiding this comment.
This was done in a separate PR already, but has not been rebased yet.
(After rebase, this line was duplicated, despite no merge conflicts)
furtib
force-pushed
the
test_into_bazel_002
branch
from
July 5, 2026 10:13
b9ecaf0 to
81c0047
Compare
furtib
added
the
non-functional change ☮️
Szelethus
requested changes
Jul 30, 2026
| unit_test( | ||
| name = "per_file_genrule_header_test", | ||
| contains = [ | ||
| "genrule_header.h", |
Collaborator
There was a problem hiding this comment.
The original test checks for "defect\(s\) in genrule_header.h"
| unit_test( | ||
| name = "per_file_genrule_source_test", | ||
| contains = [ | ||
| "genrule_source.cc", |
Comment on lines
-91
to
-93
| self.assertNotEqual( | ||
| self.contains_in_files(r"/_virtual_includes/", plist_files), [] | ||
| ) |
Collaborator
There was a problem hiding this comment.
Is this present in the new tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want our tests to run with
bazel test //....What:
Addresses:
#210