Open
Conversation
furtib
force-pushed
the
py-binary
branch
2 times, most recently
from
379462e to
318751b
Compare
nettle
reviewed
Mar 8, 2026
Collaborator
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
Looks promising! If it really works for all Bazel versions
| "codechecker_script.py", | ||
| "per_file_script.py", | ||
| ], | ||
| py_binary( |
Collaborator
There was a problem hiding this comment.
Right, this is interesting idea!
We just need to make sure it is reliable and stable in all situations
src/codechecker.bzl
Outdated
Comment on lines
+100
to
+101
| # Use environment variables instead of expand_template | ||
| environment_variables = { |
Collaborator
There was a problem hiding this comment.
However, using env vars is really creepy :)
I think we should consider arguments instead
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We should rely on Bazel to run Python scripts and not hack them together ourselves.
What:
codechecker_script.pyper_file_script.pyexpand_templatewith environment variables in codechecker ruleexpand_templatewith arguments in per_file rule (use_default_shell_env = True,does not allow us to define env variables)Addresses:
none