Skip to content

Extend external test to Bazel 8 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
furtib merged 1 commit into from
Mar 17, 2026
Merged

Extend external test to Bazel 8 #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/unit/external_repository/test_external_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,18 @@ def test_compile_commands_external_lib(self):
"-isystem bazel-out/k8-fastbuild/bin/external/"
"external_lib~override/include"
)
else:
elif self.BAZEL_VERSION.startswith("7"): # type:ignore
pattern1 = "-isystem external/external_lib~/include"
pattern2 = (
"-isystem bazel-out/k8-fastbuild/bin/external/"
"external_lib~/include"
)
else:
Comment thread
furtib marked this conversation as resolved.
pattern1 = r"-isystem external/external_lib\+/include"
pattern2 = (
r"-isystem "
r"bazel-out/k8-fastbuild/bin/external/external_lib\+/include"
)

self.assertTrue(self.contains_regex_in_file(comp_json_file, pattern1))
self.assertTrue(self.contains_regex_in_file(comp_json_file, pattern2))
Expand Down
Loading