Open
Conversation
barnabasdomozi
force-pushed
the
mypy_ci
branch
3 times, most recently
from
37ddaac to
f7208c5
Compare
Added pyproject.toml, which defines the mypy configuration. As a first step, only the codechecker_common/ folder is checked by mypy. This can be extended later. The first issue detected by mypy is that Report.report_hash could be None in several cases in the codebase. Also added installation of stub package types-psutil for mypy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
pyproject.toml, which defines the mypy configuration. As a first step, only thecodechecker_common/folder is checked by mypy. This can be extended later.The first issue detected by mypy is that
Report.report_hashcould beNonein several cases in the codebase.Also added installation of stub package
types-psutilfor mypy.