Skip to content

fix(workspace): allow git base_commit SHAs#1237

Merged
christso merged 1 commit into
mainfrom
fix/1236-base-commit-sha
May 13, 2026
Merged

fix(workspace): allow git base_commit SHAs#1237
christso merged 1 commit into
mainfrom
fix/1236-base-commit-sha

Conversation

@christso
Copy link
Copy Markdown
Collaborator

@christso christso commented May 13, 2026

Closes #1236

What changed

  • treat full workspace.repos[].checkout.base_commit SHAs as local checkout targets after clone for source.type: git repos
  • keep remote ls-remote resolution for branch/tag-style refs
  • add a regression test that reproduces the failure against a local bare git remote

Verification

  • bun test ./test/evaluation/workspace/repo-manager.test.ts in packages/core
  • bun run build
  • bun run lint
  • bun run test

Red

bun apps/cli/src/cli.ts eval issue-1236-valid-repro.eval.yaml --dry-run --target default --targets issue-1236-targets.yaml on origin/main failed during workspace setup with:

Failed to materialize repos: Ref '6e446b722627e9df017b22e391fa63320362d8c7' not found on remote https://github.com/EntityProcess/agentv\n```\n\n### Green\nThe same command on this branch completed workspace setup and ran the test case instead of erroring; the run ended as a normal assertion failure from the mock target:\n\n```text\n1/1   ⚠️ noop | default → default-dry-run | 0% FAIL\n```\n\n### Note\nIssue claiming on the project board was blocked in this environment because the configured `gh` token is missing the `read:project` scope required by `gh project item-list`.\n

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81420c8
Status: ✅  Deploy successful!
Preview URL: https://a629c2a8.agentv.pages.dev
Branch Preview URL: https://fix-1236-base-commit-sha.agentv.pages.dev

View logs

@christso christso marked this pull request as ready for review May 13, 2026 06:22
@christso christso merged commit 8c74964 into main May 13, 2026
4 checks passed
@christso christso deleted the fix/1236-base-commit-sha branch May 13, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workspace.repos checkout.base_commit fails for valid raw commit SHAs from git sources

1 participant