feat(benchmarks): add source/sync fields and benchmark repo sync#1234
Closed
christso wants to merge 0 commit into
Closed
feat(benchmarks): add source/sync fields and benchmark repo sync#1234christso wants to merge 0 commit into
christso wants to merge 0 commit into
Conversation
Deploying agentv with
|
| Latest commit: |
4ff31cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7ad0258.agentv.pages.dev |
| Branch Preview URL: | https://feat-1232-benchmark-repo-syn.agentv.pages.dev |
christso
added a commit
that referenced
this pull request
May 12, 2026
- Move syncBenchmarks() inside try/catch in serve handler so git errors produce clean console.error output rather than unhandled rejections - Remove unused 'os' import from doctor/index.ts - Remove duplicate BenchmarkSourceYaml interface (use BenchmarkSource directly) - Add explicit return type to startBenchmarkContinuous() - Update benchmarks.ts header to remove unsupported :-default syntax examples - Add test for continuous branch in syncBenchmarks - Update deps.json: correct placeholder checksums and version (v4.3.0 format), add _note explaining TODOs must be filled before shipping Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4ff31cf to
72630e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1232
Summary
BenchmarkEntrywith optionalsource: { url, ref }andsyncfieldsinterpolateEnv()is applied to all benchmark entries on load (same astargets.yamlbehavior)benchmark-sync.tsmodule with three sync modes:none(default) — no-op, path used as-isoneshot— shallowgit clone --depth 1 --filter=blob:none(idempotent if.gitexists)continuous— spawns agit-syncsidecar; fails fast with actionable error ifgit-syncis missingagentv studio/agentv servecallssyncBenchmarks()before starting the serveragentv install git-sync— downloads a pinned version with SHA-256 verification into~/.agentv/bin/agentv doctor— reportsgit-syncpresence/absence with install hintBefore/after evidence
Before: No
source/syncfields in benchmark entries; no sync capability; noagentv install/agentv doctor.After:
agentv doctoroutput (git-sync not installed):Test plan
resolveSyncMode,checkGitSyncInstalled,syncBenchmarkOneshot,syncBenchmarkssource/syncround-trip through YAMLinterpolateEnvintegration with${{ BENCH_URL }}/${{ AGENTV_SYNC }}sourceorsynccontinue to work unchanged🤖 Generated with Claude Code