Skip to content

feat(studio): pass/fail icon in eval detail h1, remove duplicate header #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christso merged 1 commit into from
May 7, 2026
Merged

feat(studio): pass/fail icon in eval detail h1, remove duplicate header #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions apps/studio/src/components/EvalDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,6 @@ export function EvalDetail({ eval: result, runId, benchmarkId }: EvalDetailProps

return (
<div className="flex min-h-full flex-col">
{/* Compact header: test ID + metadata (no scores — scores live in Checks tab) */}
<div className="flex items-start justify-between border-b border-gray-800 px-4 py-3">
<div>
<h3 className="text-lg font-medium">{result.testId}</h3>
<p className="mt-0.5 text-sm text-gray-400">
{result.target && <span>Target: {result.target}</span>}
{result.durationMs != null && (
<span className="ml-4">{(result.durationMs / 1000).toFixed(1)}s</span>
)}
{result.costUsd != null && <span className="ml-4">${result.costUsd.toFixed(4)}</span>}
</p>
</div>
</div>

{/* Tab navigation — at the top so Files tab editor fills maximum height */}
<div className="border-b border-gray-800">
<div className="flex gap-1 px-4">
Expand Down
15 changes: 13 additions & 2 deletions apps/studio/src/routes/benchmarks/$benchmarkId_/evals/$runId.$evalId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useState } from 'react';

import { EvalDetail } from '~/components/EvalDetail';
import { RunEvalModal } from '~/components/RunEvalModal';
import { useBenchmarkRunDetail, useStudioConfig } from '~/lib/api';
import { isPassing, useBenchmarkRunDetail, useStudioConfig } from '~/lib/api';

export const Route = createFileRoute('/benchmarks/$benchmarkId_/evals/$runId/$evalId')({
component: BenchmarkEvalDetailPage,
Expand Down Expand Up @@ -50,14 +50,25 @@ function BenchmarkEvalDetailPage() {
);
}

const passThreshold = config?.threshold ?? config?.pass_threshold ?? 0.8;
const passed =
isPassing(result.score, passThreshold) &&
result.executionStatus !== 'error' &&
result.executionStatus !== 'failed';

return (
<div className="flex h-full flex-col gap-6">
<div className="flex items-center justify-between">
<div>
<p className="text-sm text-gray-400">
Run: {runId} / Eval: {evalId}
</p>
<h1 className="text-2xl font-semibold text-white">{evalId}</h1>
<h1 className="flex items-center gap-2 text-2xl font-semibold text-white">
<span className={`text-2xl font-bold leading-none ${passed ? 'text-emerald-400' : 'text-red-400'}`}>
{passed ? '✓' : '✗'}
</span>
{evalId}
</h1>
</div>
{!isReadOnly && (
<button
Expand Down
15 changes: 13 additions & 2 deletions apps/studio/src/routes/evals/$runId.$evalId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useState } from 'react';

import { EvalDetail } from '~/components/EvalDetail';
import { RunEvalModal } from '~/components/RunEvalModal';
import { useRunDetail, useStudioConfig } from '~/lib/api';
import { isPassing, useRunDetail, useStudioConfig } from '~/lib/api';

export const Route = createFileRoute('/evals/$runId/$evalId')({
component: EvalDetailPage,
Expand Down Expand Up @@ -54,14 +54,25 @@ function EvalDetailPage() {
);
}

const passThreshold = config?.threshold ?? config?.pass_threshold ?? 0.8;
const passed =
isPassing(result.score, passThreshold) &&
result.executionStatus !== 'error' &&
result.executionStatus !== 'failed';

return (
<div className="flex h-full flex-col gap-6">
<div className="flex items-center justify-between">
<div>
<p className="text-sm text-gray-400">
Run: {runId} / Eval: {evalId}
</p>
<h1 className="text-2xl font-semibold text-white">{evalId}</h1>
<h1 className="flex items-center gap-2 text-2xl font-semibold text-white">
<span className={`text-2xl font-bold leading-none ${passed ? 'text-emerald-400' : 'text-red-400'}`}>
{passed ? '✓' : '✗'}
</span>
{evalId}
</h1>
</div>
{!isReadOnly && (
<button
Expand Down
Loading