Fix formatting inconsistency#560
Open
EdwinChang24 wants to merge 1 commit intoEnterpriseQualityCoding:uinversefrom
Open
Fix formatting inconsistency#560EdwinChang24 wants to merge 1 commit intoEnterpriseQualityCoding:uinversefrom
EdwinChang24 wants to merge 1 commit intoEnterpriseQualityCoding:uinversefrom
Conversation
knakamura13
suggested changes
Jun 19, 2022
| public final class FizzBuzzOutputStrategyToFizzBuzzExceptionSafeOutputStrategyAdapter implements FizzBuzzExceptionSafeOutputStrategy { | ||
|
|
||
| private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy; | ||
| private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy; |
There was a problem hiding this comment.
There should only be one space following the keyword private rather than three spaces. Please revise your PR to reflect the code formatting seen in existing instances of private final such as on line 17 in the LoopComponentFactory.
My proposed change to your PR looks like this:
private final FizzBuzzOutputStrategy _fizzBuzzOutputStrategy;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It came to my attention that an inconsistency in formatting was present, therefore I felt obliged to amend it. Please visit my office in the janitor's closet on the west side of floor 17 for inquiries.