Update to 3.0.0-ALPHA11#9
Open
95CivicSi wants to merge 4 commits intoEnrick3344:masterfrom
95CivicSi:3.0.0-ALPHA11
Open
Update to 3.0.0-ALPHA11#995CivicSi wants to merge 4 commits intoEnrick3344:masterfrom 95CivicSi:3.0.0-ALPHA11
95CivicSi wants to merge 4 commits intoEnrick3344:masterfrom
95CivicSi:3.0.0-ALPHA11
Conversation
… namespace with the current item, it is not necessary to import that class or item.
…mber of time that the configuration file is accessed for any variable, performance is increased. Also updated some methods to ensure that Player methods are only called on Players.
…o ensure Command Sender is a Player before calling Player methods during commands. Fixed undefined variables $level on 251 and 284.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update will bring FantasyProtection up to speed with PocketMine-MP 3.0.0-ALPHA11. No backwards compatible changes were made, There were changes to clean the code up and fix some existing errors Examples would be:
When using a config file for things similar to this, it is useful to avoid accessing the hard drive (by accessing the config file) whenever possible. Every function call and file access is increased amount of time which can cause lag. Commonly used variables should be stored in memory and updated only as needed.