Fix lock flag restoration after session reinitialization - #2304
Open
Brokkonaut wants to merge 1 commit into
Open
Fix lock flag restoration after session reinitialization#2304Brokkonaut wants to merge 1 commit into
Brokkonaut wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix player-specific weather and time state restoration when sessions are
reinitialized.
Players could remain stuck with the weather configured by a region's
weather-lock flag after leaving the region. This was reproducible when:
region (for example login after the server was restarted) or
Moving out of that region would not reset the weather/time to normal afterwards
Cause
New sessions were already initialized by SessionManager#get, but the
ProcessPlayerEvent handler initialized them a second time. During the second
initialization, the weather applied by WorldGuard was recorded as the player's
original weather.
Additionally, Session#resetState initialized handlers again without first
uninitializing them. Stateful handlers could therefore replace their original
player state with the state previously applied by the region flag.
Changes