Conversation
me4502
left a comment
me4502
left a comment
There was a problem hiding this comment.
Thanks for this. It appears to mostly follow along with the same goals from the WorldEdit Folia support.
I've left a few comments on some parts that I feel would be worth cleaning up
worldguard-bukkit/src/main/java/com/sk89q/worldguard/bukkit/util/report/SchedulerReport.java
Outdated
Show resolved
Hide resolved
worldguard-bukkit/src/main/java/com/sk89q/worldguard/bukkit/listener/PlayerMoveListener.java
Outdated
Show resolved
Hide resolved
worldguard-bukkit/src/main/java/com/sk89q/worldguard/bukkit/listener/PlayerMoveListener.java
Outdated
Show resolved
Hide resolved
...ard-bukkit/src/main/java/com/sk89q/worldguard/bukkit/listener/WorldGuardVehicleListener.java
Outdated
Show resolved
Hide resolved
|
That should be good, I also took the liberty of removing duplicates for |
| vehicle.teleport(override.clone()); | ||
| Location vehicleTeleportLocation = override.clone(); | ||
| if (getPlugin().isFolia()) { | ||
| PaperLib.teleportAsync(vehicle, vehicleTeleportLocation); |
There was a problem hiding this comment.
I don't think there is a reason to use PaperLib only for folia. Imo we could always use PaperLib which provides fallback stuff for spigot.
There was a problem hiding this comment.
The potential problem would be that there could be a desynchronization between several teleportations on the Paper or Bukkit servers, which are currently a synchronous call
An issue has been created for WorldEdit regarding an API; if we know it won't cause any problems, I can merge using PaperLib for Bukkit like Folia.
3 participants
Following the basic Folia support for WorldEdit, this PR adds basic Folia support.
Some testing still needs to be done.