ref: Migrate Hacker News examples to Sentry#825
Open
cameroncooke wants to merge 3 commits into
Open
Conversation
Sentry Snapshot Testing
|
📲 Install BuildsiOS
Android
|
3b93d94 to
b9fa731
Compare
Replace Emerge's suite of products with Sentry for size analysis, snapshot testing, and distribution across both platforms. This removes the Emerge Gradle plugin, fastlane plugin, SDK dependencies, snapshot maven repos, and emerge_config.yaml in favor of their Sentry equivalents. Rename the CI workflows from ios/android_emerge_* to *_sentry_* and drop the now-redundant ios_emerge_upload_snapshots workflow. Update the README, app metadata, and "built by" UI to reference Sentry instead of Emerge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b9fa731 to
63f2e65
Compare
Move comment loading out of the view model initializer so previews can hold deterministic fixture state. Add a narrow per-preview diff threshold for the Send Feedback raster-only close icon diff. Co-Authored-By: Codex <noreply@openai.com>
The Swift Snapshot Testing upload lane shared the same app_id as the main app, causing its snapshots to be grouped under the wrong app in Sentry. Use a dedicated app_id so these snapshots are tracked separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
NicoHinderling
approved these changes
Jun 18, 2026
| SentrySDK.start { options in | ||
| options.dsn = | ||
| "https://118cff4b239bd3e0ede8fd74aad9bf8f@o497846.ingest.sentry.io/4506027753668608" | ||
| "https://c726216bd362ec0bf67044f1ad1e8ffc@o1.ingest.us.sentry.io/4510761392078848" |
Contributor
There was a problem hiding this comment.
Why did this DSN change?
Contributor
Author
There was a problem hiding this comment.
I moved the app to the sentry org instead of emerge tools so it matches the Android app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Emerge Tools branding and replace with Sentry branding, this repo acts as a best-in-class example for integration Snapshots, Size Analysis and Distribution.
Changes:
hackernews-iosproject instead of the Emerge Tools org.hackernews-androidproject in the main Sentry org.Refs EME-1200