Skip to content

Greptile fix on #28: render different maps per iteration #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smrifaki wants to merge 1 commit into
base: mohit/fix-render
Choose a base branch
from
Open

Greptile fix on #28: render different maps per iteration #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions pufferlib/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,8 +480,8 @@ def render_human_replay_videos(config, policy_bin_path, output_dir, num_maps=5,
env_config = config.get("env_config", config.get("env", {}))
k_scenarios = env_config.get("k_scenarios", 2)

# Build command for human replay rendering
cmd = [
# Base command for human replay rendering (per-map --map-name added inside loop)
base_cmd = [
"xvfb-run",
"-a",
"-s",
Expand Down Expand Up @@ -511,7 +511,20 @@ def render_human_replay_videos(config, policy_bin_path, output_dir, num_maps=5,
videos_to_log_world = []
videos_to_log_agent = []

# Greptile fix: vary --map-name per iteration so the loop renders different maps
# rather than the same one repeatedly. Try both map_NNN.bin naming patterns
# (some datasets start at 000, others at 001).
map_dir = "resources/drive/binaries/training"
for map_idx in range(num_maps):
map_path_a = os.path.join(map_dir, f"map_{map_idx:03d}.bin")
map_path_b = os.path.join(map_dir, f"map_{map_idx + 1:03d}.bin")
if os.path.exists(map_path_a):
cmd = base_cmd + ["--map-name", map_path_a]
elif os.path.exists(map_path_b):
cmd = base_cmd + ["--map-name", map_path_b]
else:
print(f"No map binary found for index {map_idx} in {map_dir}, skipping")
continue
result = subprocess.run(cmd, cwd=os.getcwd(), capture_output=True, text=True, timeout=600, env=env_vars)

vids_exist = os.path.exists("resources/drive/output_topdown.mp4") and os.path.exists(
Expand Down
Loading