Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the curator “Users” page performance and usability by introducing a “max age” (registration date) filter, defaulting that filter when navigating from notifications/menus, and moving user-curation UI strings toward I18n.
Changes:
- Add
max_agefiltering toCuratorController#usersand surface it as a new dropdown filter on the curation page. - Default curation links (user menu + approval emails) to
max_age=1.monthto reduce slow initial loads. - Introduce I18n keys for the user curation page and refactor recent activity formatting / curation JS into
app/assets/javascripts/curation.js.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/controllers/curator_controller_test.rb | Update assertions for recent activity text formatting. |
| config/locales/en.yml | Add I18n keys for user curation page UI and activity strings. |
| app/views/layouts/_user_menu.html.erb | Add default max_age param to “Curate users” link. |
| app/views/curator/users.html.erb | Add max-age dropdown, apply I18n, refactor page structure, remove inline JS. |
| app/views/curation_mailer/user_requires_approval.text.erb | Add default max_age param to email deep-link. |
| app/views/curation_mailer/user_requires_approval.html.erb | Add default max_age param to email deep-link. |
| app/helpers/curators_helper.rb | Add max-age option helper + I18n-based approval labels. |
| app/controllers/curator_controller.rb | Implement max_age parsing/filtering for the users query. |
| app/assets/javascripts/curation.js | Add JS helpers for filter param application and curate-user AJAX. |
| app/assets/javascripts/application.js | Initialize Curation.init() on Turbolinks load. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
Initial load was very slow on ELIXIR TeSS due to the "with content" check iterating over a large number of users.
Checklist