Adding log rotation using lumberjack#423
Adding log rotation using lumberjack#423sergey3bv wants to merge 2 commits intoElementsProject:masterfrom
Conversation
YusukeShimizu
left a comment
There was a problem hiding this comment.
Thank you for the log rotation update; this is a valuable improvement overall.
I have one concern that looks blocking, so I’m marking this as request changes for now and would appreciate a quick confirmation.
9c3993a to
659b3f0
Compare
|
Hey, @YusukeShimizu, I updated the PR accordingly, could you please review it? Also are there any issues I can help with? |
659b3f0 to
eda6a6e
Compare
|
Thanks for addressing the earlier feedback and improving the log rotation overall! If my understanding is correct, there are two points we might need to address before merging:
Let me know your thoughts on this! |
As I am thinking about it now we can leave the current flow and store rotated logs nearby. For example, logs will still be written in |
Good point, I will fix it right away |
eda6a6e to
6c79ea8
Compare
|
That sounds like a good direction to me. Keeping the active log at the current /log path would avoid the upgrade compatibility issue, and it should reduce friction for existing deployments. |
@YusukeShimizu
@nepet
Addressing #301