Skip to content

docker: make local builds work without version arg #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
longbiaochen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docker: make local builds work without version arg #9135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae9add8
docker: make local builds work without version arg
longbiaochen May 14, 2026
4d8282d
Preserve derived Docker build versions
longbiaochen May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ ARG STRIP=${target_arch}-strip
ARG TARGET=${target_arch_rust}
ARG RUST_PROFILE=release
ARG VERSION
ENV VERSION=${VERSION}
ARG MAKE_JOBS

#TODO: set all the following cargo config options via env variables (https://doc.rust-lang.org/cargo/reference/environment-variables.html)
RUN mkdir -p .cargo && tee .cargo/config.toml <<EOF
Expand Down Expand Up @@ -155,7 +155,11 @@ COPY .git/ .git/
RUN git submodule update --init --recursive --jobs $(nproc) --depth 1

RUN ./configure --prefix=/tmp/lightning_install --enable-static --disable-compat --disable-valgrind
RUN uv run make install-program -j$(nproc)
RUN if [ -n "${VERSION:-}" ]; then \
VERSION="${VERSION}" uv run make install-program -j"${MAKE_JOBS:-$(nproc)}"; \
else \
uv run make install-program -j"${MAKE_JOBS:-$(nproc)}"; \
fi

RUN find /tmp/lightning_install -type f -executable -exec \
file {} + | \
Expand Down Expand Up @@ -284,4 +288,4 @@ VOLUME ["/root/.lightning"]
ENTRYPOINT ["/entrypoint.sh"]

# Default target (for backward compatibility)
FROM lightningd AS final
FROM lightningd AS final