splice: Take splice out of experimental mode!#9021
Open
ddustin wants to merge 4 commits intoElementsProject:masterfrom
Open
splice: Take splice out of experimental mode!#9021ddustin wants to merge 4 commits intoElementsProject:masterfrom
ddustin wants to merge 4 commits intoElementsProject:masterfrom
Conversation
a38d635 to
c170ea0
Compare
53a144f to
119e87a
Compare
Fix leaking of the `abort_pkg` if our peer does not support splicing.
Turn splicing on by default for channel feature sets! Changelog-Added: Splicing is now enabled by default!
856fbee to
9f31c41
Compare
When the doc generator fails, make the CI output the diff of how it failed.
9f31c41 to
878f6f3
Compare
Contributor
|
It's good, but a bit overzealous. We need to silently accept it and run a full deprecation period. This avoids breaking people's configs when they upgrade (and by the time we do remove it, in 12 months, they don't have to worry about downgrading). See this example: Then update doc/developers-guide/deprecations.md, and Changelog-Deprecated it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn on splicing by default and remove the experimental splicing feature!