Skip to content

splice: Take splice out of experimental mode!#9021

Open
ddustin wants to merge 4 commits intoElementsProject:masterfrom
ddustin:ddustin/splicing-release
Open

splice: Take splice out of experimental mode!#9021
ddustin wants to merge 4 commits intoElementsProject:masterfrom
ddustin:ddustin/splicing-release

Conversation

@ddustin
Copy link
Copy Markdown
Collaborator

@ddustin ddustin commented Apr 2, 2026

Turn on splicing by default and remove the experimental splicing feature!

@ddustin ddustin requested a review from cdecker as a code owner April 2, 2026 02:19
@ddustin ddustin force-pushed the ddustin/splicing-release branch 2 times, most recently from a38d635 to c170ea0 Compare April 2, 2026 02:24
@ddustin ddustin added this to the v26.04 milestone Apr 2, 2026
@ddustin ddustin force-pushed the ddustin/splicing-release branch 2 times, most recently from 53a144f to 119e87a Compare April 2, 2026 03:00
ddustin added 2 commits April 2, 2026 10:27
Fix leaking of the `abort_pkg` if our peer does not support splicing.
Turn splicing on by default for channel feature sets!

Changelog-Added: Splicing is now enabled by default!
@ddustin ddustin force-pushed the ddustin/splicing-release branch 2 times, most recently from 856fbee to 9f31c41 Compare April 2, 2026 14:52
ddustin added 2 commits April 2, 2026 11:25
When the doc generator fails, make the CI output the diff of how it failed.
@ddustin ddustin force-pushed the ddustin/splicing-release branch from 9f31c41 to 878f6f3 Compare April 2, 2026 15:26
@ddustin ddustin requested review from rustyrussell April 2, 2026 19:18
@rustyrussell
Copy link
Copy Markdown
Contributor

It's good, but a bit overzealous. We need to silently accept it and run a full deprecation period. This avoids breaking people's configs when they upgrade (and by the time we do remove it, in 12 months, they don't have to worry about downgrading).

See this example:

static char *opt_set_hsm_password(struct lightningd *ld)
{
	int is_encrypted;

	/* Show deprecation warning */
	if (!opt_deprecated_ok(ld, "encrypted_hsm",
			      "Use --hsm-passphrase instead",
			      "v25.12", "v26.12"))
		return "--encrypted-hsm was removed, use --hsm-passphrase instead";

Then update doc/developers-guide/deprecations.md, and Changelog-Deprecated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants