Skip to content

bkpr report enhancements#9020

Merged
sangbida merged 3 commits intoElementsProject:masterfrom
rustyrussell:guilt/bkpr-report-enhancements
Apr 2, 2026
Merged

bkpr report enhancements#9020
sangbida merged 3 commits intoElementsProject:masterfrom
rustyrussell:guilt/bkpr-report-enhancements

Conversation

@rustyrussell
Copy link
Copy Markdown
Contributor

@rustyrussell rustyrussell commented Apr 2, 2026

This changes the format of bkpr-report, so I'd really like it in before release so we can avoid breakage.

It's much more powerful now: should keep Accounting happy!

Changelog-None

rustyrussell and others added 2 commits April 2, 2026 12:24
They should test if it's zero, not if it's present.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…:if-not-set}

This is more powerful, but we need to do this before release.  It lets
us do things like: {credit?+{credit}:0} to only put a `+` in front of
no-zero credit, and {txid?TXID {txid}:Outpoint {outpoint}} to print
either `TXID xxx` or `Outpoint xxx`.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rustyrussell rustyrussell requested a review from cdecker as a code owner April 2, 2026 02:16
@rustyrussell rustyrussell added this to the v26.04 milestone Apr 2, 2026
This should make the accountants happy!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@sangbida sangbida force-pushed the guilt/bkpr-report-enhancements branch from 7d541c1 to 75f27c1 Compare April 2, 2026 03:10
@sangbida sangbida enabled auto-merge (rebase) April 2, 2026 04:06
@sangbida sangbida disabled auto-merge April 2, 2026 04:54
@sangbida sangbida merged commit f067b73 into ElementsProject:master Apr 2, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants