py: add pyln-grpc-proto to PyPI publishing CI#8999
Open
ThomsenDrake wants to merge 1 commit intoElementsProject:masterfrom
Open
py: add pyln-grpc-proto to PyPI publishing CI#8999ThomsenDrake wants to merge 1 commit intoElementsProject:masterfrom
ThomsenDrake wants to merge 1 commit intoElementsProject:masterfrom
Conversation
…7929) Add pyln-grpc-proto to the pypi.yml publish matrix and create a dedicated update-pyln-grpc-version Makefile target that handles the package's non-standard directory layout (pyln/grpc/ instead of pyln/grpc-proto/) and strips the v-prefix from version tags. Also syncs the stale __version__ in pyln/grpc/__init__.py to match pyproject.toml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7929 — Add
pyln-grpc-prototo the PyPI publishing workflow so the package is automatically published on release.Changes
.github/workflows/pypi.yml— Addedpyln-grpc-prototo the publish matrix (same pattern aspyln-client,pyln-proto,pyln-testing)Makefile— Added a dedicatedupdate-pyln-grpc-versiontarget that handles the versioning differences:pyln/grpc/instead ofpyln/grpc-proto/25.09(novprefix), while the tag isv25.09contrib/pyln-grpc-proto/pyln/grpc/__init__.py— Synced stale__version__from"0.1.1"to"25.09"to matchpyproject.tomlWhy a custom Makefile target?
The existing
update-pyln-version-%pattern assumes:contrib/pyln-<name>/pyln/<name>/__init__.pygit describepyln-grpc-protobreaks both assumptions:contrib/pyln-grpc-proto/pyln/grpc/__init__.pyvprefix stripped for PyPIThe custom target is the minimal approach — it follows the exact same `` pattern as the generic targets and integrates into
update-pyln-versionsas a dependency.