fix: release txprepare reservations on send failure#8989
Open
vincenzopalazzo wants to merge 2 commits intoElementsProject:masterfrom
Open
fix: release txprepare reservations on send failure#8989vincenzopalazzo wants to merge 2 commits intoElementsProject:masterfrom
vincenzopalazzo wants to merge 2 commits intoElementsProject:masterfrom
Conversation
Clean up the original PSBT reservation when withdraw/txsend fail after signing or broadcast. Include the final withdraw regression coverage, including the liquid-safe address handling needed for CI. Fixes ElementsProject#8925
Stabilize unrelated valgrind flakes encountered while validating the withdraw reservation fix. Disable cln-grpc in gossip tests that do not exercise grpc startup, relax the duplicate channel_announcement expectation under valgrind, and fix the expected broken-log pattern in test_important_plugin.
vincenzopalazzo
force-pushed
the
codex/fix-withdraw-unreserve-8925
branch
from
2b4ff9f to
a8c5646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
withdrawandtxsendreserve inputs through the initialfundpsbt/utxopsbtcall, then hand the PSBT tosignpsbtandsendpsbt. If signing or broadcasting fails, the plugin forwarded the error without callingunreserveinputs, so the original reservation remained stuck even though the immediate-send flow had aborted.Verification
uv run --group dev pytest tests/test_wallet.py -k withdraw_unreserves_inputs_on_send_failure -quv run --group dev pytest tests/test_wallet.py -k 'test_txsend or test_withdraw' -q\n\nChangelog-None\n\nFixes Double-reservation in thewithdrawflow #8925