Skip to content

Makefile: remove build prerequisites from install targets (fixes #8971) #8976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThomsenDrake wants to merge 1 commit into from
+4 −2
Closed

Makefile: remove build prerequisites from install targets (fixes #8971) #8976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,9 @@ installdirs:

# $(PLUGINS) is defined in plugins/Makefile.

install-program: installdirs $(BIN_PROGRAMS) $(PKGLIBEXEC_PROGRAMS) $(PLUGINS) $(PY_PLUGINS)
# make install should only copy pre-built files, never trigger builds.
# Building is done via 'make' or 'make all'; see #8971.
install-program: installdirs
@$(NORMAL_INSTALL)
$(INSTALL_PROGRAM) $(BIN_PROGRAMS) $(DESTDIR)$(bindir)
$(INSTALL_PROGRAM) $(PKGLIBEXEC_PROGRAMS) $(DESTDIR)$(pkglibexecdir)
Expand All @@ -955,7 +957,7 @@ MAN7PAGES = $(filter %.7,$(MANPAGES))
MAN8PAGES = $(filter %.8,$(MANPAGES))
DOC_DATA = README.md LICENSE

install-data: installdirs $(MAN1PAGES) $(MAN5PAGES) $(MAN7PAGES) $(MAN8PAGES) $(DOC_DATA)
install-data: installdirs
Copy link
Copy Markdown
Collaborator

@vincenzopalazzo vincenzopalazzo Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes installcheck stop being self-contained. That target still only depends on all-programs, so on a clean tree it reaches make install without the manpages from doc-all; on Rust-enabled builds it can also miss the builtin plugins, since those live under DEFAULT_TARGETS, not ALL_PROGRAMS. Today the prerequisites removed in this PR are what make installcheck/check and bin-tarball work without a prior full make. Can we move the build deps up to those higher-level targets instead of dropping them here?

@$(NORMAL_INSTALL)
$(INSTALL_DATA) $(MAN1PAGES) $(DESTDIR)$(man1dir)
$(INSTALL_DATA) $(MAN5PAGES) $(DESTDIR)$(man5dir)
Expand Down