Mnemonic hsm_secret tests #8837
Open
+428
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
hsm-secret-fixes-with-tests
branch
3 times, most recently
from
8bdafaa to
02b6274
Compare
Since we have changed our hsm_secret seed the node ids have all change hence the asseertions on the scids break. This changes it so that the direction is determined when the test executes.
This defaults to false for now: this breaks a lot of tests (since node ids change!) once we switch to true.
Anything using a canned db depends on the node ids being generated from the old hsm seed.
We only support downgrade if you upgraded, so your hsm_secret will be old. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
bookkeeper's fee tracking depends on deterministic channel structure, which depends on node ID ordering. I'm marking this with the old_hsmsecret option for now.
This test has been split into two to assert on both the old and the new hsm_secret
These are explicitly written to check that the values don't accidentally change, which applies to both old and new styles. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Another one we want to make sure stays unchanged. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… parameterize test_recover_command. This matters for mnemonic nodes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This changes various tests in minor ways: 1. The "l2" secret key in tests/plugins/channeld_fakenet.c is updated. 2. The decompressed gossip data node id needs changing. 3. The coinmoves order changes in bookkeeper for anchors. 4. Various harcoded gossip constants change. 5. Some hardcoded makesecret results change. 6. zeroconf tests which hardcoded node ids change. 7. Arbitrary rune strings change. 8. A log message which uses node ids changes.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
hsm-secret-fixes-with-tests
branch
from
02b6274 to
037d076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8831
This is a separate PR because we don't need to port this back to v25.12.1
Changelog-None: tests only