Closed
Conversation
Changelog-Fixed: fix reservation leak in version 25.05 Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Log when a reservation removal failures during getroutes computation. Failed reservation removals can lead to reservation leaks. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Collaborator
|
Thanks for looking into this this is exactly what I was assuming inside the issude, please can you backport the commit e15614c to the v25.05 due that the continues point release of v25.09 I am not confident that the upgrade of the node can be justfied |
Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
reservations-leak-v25.05
branch
from
55e7fe9 to
4199c2a
Compare
cdecker
approved these changes
Nov 10, 2025
Collaborator
Author
|
This can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the reservation leak reported in issue #8663.
It should not be merged to the master branch because the tip does not contain the same bug.
It is meant to be used as a patch for point releases of v25.05 if any.