Revert "fix(Upload): always apply accept filter in onChange handler"#1138
Merged
ashutosh-tanwar-eightfold merged 3 commits intoJul 7, 2026
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 1230 1230
Lines 21542 21542
Branches 8184 8185 +1
=======================================
Hits 18306 18306
Misses 3150 3150
Partials 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ychhabra-eightfold
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1102
What #1102 did & why
AjaxUploader.onChangeused to pass every picked file through touploadFiles→beforeUpload/customRequest, leaving type checks to the consumer. #1102 changed it to always runattrAccept:It was added to block a customer bug (CS-15960) where users bypassed the picker via "All Files" and uploaded unsupported types.
Why revert now
acceptis a browser hint, not enforcement — and runningattrAccepthere silently drops mismatched files beforebeforeUpload/customRequestfire. Consumers that validate in those callbacks and show their own error lost that path entirely: the file just vanishes, no feedback. Regression: ENG-200748 (also traced in vscode#110534).This restores the pre-#1102 pass-through: directory uploads still filter; file-picker uploads reach the consumer callbacks.
Before upgrading vscode
The original CS-15960 consumer (
FileUpload.tsx) does no type check of its own, so reverting alone reopens it. It's being fixed at the consumer in vscode#110938 — land that first / in the same octuple bump.