Adding 2 new mdi icons#1129
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 1230 1230
Lines 21425 21425
Branches 8129 8129
=======================================
Hits 18076 18076
Misses 3262 3262
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samyakj-eightfold
approved these changes
May 26, 2026
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Adds two Material Design Icons to the IconName enum in src/components/Icon/mdi.ts: mdiArrowDecisionOutline (SVG · Pictogrammers) and mdiCreation (SVG · Pictogrammers). Both are cherry-picked from the upstream Templarian/MaterialDesign-JS reference noted at the top of the file. Entries are added as camelCase enum members in alphabetical order — mdiArrowDecisionOutline between mdiArrowCollapseUp and mdiArrowDown, and mdiCreation between mdiCopilotIconSmall and mdiCurrencyUsd. No other files changed.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-194454
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Just added two new icons, no new tests required as such