Skip to content

fix(Snackbar): add aria-hidden to empty snackbar position regions#1124

Merged
ychhabra-eightfold merged 2 commits into
EightfoldAI:mainfrom
ksharma-c-eightfold:notification_SE_fix
May 5, 2026
Merged

fix(Snackbar): add aria-hidden to empty snackbar position regions#1124
ychhabra-eightfold merged 2 commits into
EightfoldAI:mainfrom
ksharma-c-eightfold:notification_SE_fix

Conversation

@ksharma-c-eightfold
Copy link
Copy Markdown
Contributor

@ksharma-c-eightfold ksharma-c-eightfold commented Apr 28, 2026

SUMMARY:

For ENG-192648:-
Problem:-Too many announcements of notifications - On this page, screen reader announces “Notifications region” multiple times which is confusing to the reader.

Solution:- Fix the notification region issue through aria-hidden true.

For ENG-192652:-
Problem:- Screen Reader Focuses and Announces “Notification Region” Multiple Times Without Context.
Occurs across all screens after the Get Help button in the footer.
When navigating with the Down Arrow key after the Get Help button:
• The term “Notification region” is focused and announced multiple times by the screen reader.
• No visible notifications are present, and the purpose of this region is unclear.
• This behavior is misleading and disrupts navigation for screen reader users.
Repeated focus and announcement of an unexplained region creates confusion, increases cognitive load, and negatively affects accessibility.

Solution:- Fix the notification region issue through aria-hidden true.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-192648
https://eightfoldai.atlassian.net/browse/ENG-192652

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

SnackbarContainer sets aria-hidden="true" on any of the 6 position role="region" divs that have no active snacks, and removes it when a snack is present.

All 6 regions on initial render | Every [role="region"] has aria-hidden="true"

Screen.Recording.2026-04-27.at.12.07.37.AM.mov
Screen.Recording.2026-04-26.at.11.05.49.PM.mov
image

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Apr 28, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ychhabra-eightfold ychhabra-eightfold merged commit 8d2418d into EightfoldAI:main May 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants