fix(Select): updated aria-live property for results announcement#1114
Open
ssherigar-c-eightfold wants to merge 1 commit intoEightfoldAI:mainfrom
Open
fix(Select): updated aria-live property for results announcement#1114ssherigar-c-eightfold wants to merge 1 commit intoEightfoldAI:mainfrom
ssherigar-c-eightfold wants to merge 1 commit intoEightfoldAI:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Select
Added aria-live="polite" region for result announcements
Added aria-haspopup="listbox" to trigger
Passed aria-label to Menu
GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-167744
https://eightfoldai.atlassian.net/browse/ENG-167639
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Dropdown Input Select
Live region announces results correctly
Announces result count (“4 results available”)
when No result ("No results found for test")
Trigger has correct ARIA and retains focus
Keyboard navigation uses aria-activedescendant
Roles and labels applied correctly