Skip to content

feat(FilterCheckboxDropdown): create accessible filter checkbox dropdown component#1112

Closed
ksharma-c-eightfold wants to merge 2 commits intoEightfoldAI:mainfrom
ksharma-c-eightfold:custom_drop_down
Closed

feat(FilterCheckboxDropdown): create accessible filter checkbox dropdown component#1112
ksharma-c-eightfold wants to merge 2 commits intoEightfoldAI:mainfrom
ksharma-c-eightfold:custom_drop_down

Conversation

@ksharma-c-eightfold
Copy link
Copy Markdown
Contributor

SUMMARY:

  • Created a new accessible filter checkbox dropdown component.
  • This is created as an expandable buttons with checkboxes rather than dropdowns.
  • It does not contain aria-haspopup & role=combobox attributes from the expandable elements.
  • Also we removed the role="option" and role="listbox" roles from the checkboxes.
  • As well as added Fieldset and legend for the checkbox.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-167512

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

image image image

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Mar 31, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants