fix(Avatar): remove tabIndex from img type avatar#1110
Merged
ychhabra-eightfold merged 2 commits intoEightfoldAI:mainfrom Mar 30, 2026
Merged
fix(Avatar): remove tabIndex from img type avatar#1110ychhabra-eightfold merged 2 commits intoEightfoldAI:mainfrom
ychhabra-eightfold merged 2 commits intoEightfoldAI:mainfrom
Conversation
Images are not interactive elements and should not have tabIndex populated. This prevents unnecessary keyboard focusability on image avatars. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ychhabra-eightfold
requested review from
akankal-eightfold and
sivahari-a-1-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sivahari-a-1-eightfold
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Remove
tabIndexfrom the<img>element when Avatar renders with asrcprop. Images are not interactive elements and should not havetabIndexpopulated, preventing unnecessary keyboard focusability on image avatars.GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
tabindexattribute in the DOMtabIndexas before🤖 Generated with Claude Code