fix(openapi): preserve JSON.rawJSON in cached specs - #7250
Open
xianjianlf2 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: c4045ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.rawJSONvalues when cloning cached OpenAPI specsOpenApi.fromApicalls with a raw JSON extension valueeffectDetails
JSON.rawJSONobjects carry internal JSON serialization behavior. The cached spec clone added in #6550 recursively copied enumerable object keys, which turned a raw JSON object into a plain{ rawJSON: ... }object on cache hits. The clone now detects raw JSON values withJSON.isRawJSONand keeps them intact.Tests
pnpm test packages/effect/test/unstable/httpapi/OpenApi.test.tspnpm --dir packages/effect checkpnpm exec oxlint packages/effect/src/unstable/httpapi/OpenApi.ts packages/effect/test/unstable/httpapi/OpenApi.test.tspnpm exec dprint check .changeset/preserve-openapi-raw-json.md packages/effect/src/unstable/httpapi/OpenApi.ts packages/effect/test/unstable/httpapi/OpenApi.test.tsgit diff --checkFixes #7239