Skip to content

Pin fixed next release action - #6981

Merged
IMax153 merged 3 commits into
mainfrom
test/release-queue-inputs
Aug 4, 2026
Merged

Pin fixed next release action#6981
IMax153 merged 3 commits into
mainfrom
test/release-queue-inputs

Conversation

@IMax153

@IMax153 IMax153 commented Aug 4, 2026

Copy link
Copy Markdown
Member

Purpose

Pin the release queue workflow to the merged next-release-action config-provider fix. This allows the action to read the configured v4/next-minor and v4/next-major branches instead of using its fallback branch names.

Action fix: Effect-TS/next-release-action#3

Verification

  • pnpm lint
  • git diff --check

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 96857d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@effect-slopcop effect-slopcop Bot added 4.0 enhancement New feature or request labels Aug 4, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Added .github/workflows/release-queue-input-diagnostic.yml, a temporary workflow that runs the unmerged next-release-action diagnostic path on GitHub-hosted runners to compare raw and parsed eligible_branches input.

The workflow follows the claimed safety constraints: it triggers only on pull_request, grants only contents: read, passes the default ${{ github.token }} rather than the bot token, and invokes a pinned SHA of next-release-action with NEXT_RELEASE_ACTION_DIAGNOSTIC: "true" so the action exits before constructing GitHub or git services.

Pullfrog  | ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@IMax153

IMax153 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Diagnostic completed successfully. The runner exposed INPUT_ELIGIBLE_BRANCHES=v4/next-minor,v4/next-major, and the fixed MainLayer parsed ["v4/next-minor", "v4/next-major"]. No branch mutation code ran.

Result: https://github.com/Effect-TS/effect/actions/runs/30914706194/job/92009757386

The production fix is in Effect-TS/next-release-action#3.

@IMax153 IMax153 closed this Aug 4, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Updated the pinned Effect-TS/next-release-action SHA from adcadc4 to 424506b so the diagnostic workflow exercises the action PR's Layer.provideMerge fix, which exposes the constant-case ConfigProvider to the main effect's input reads.

  • Confirmed the rest of the workflow remains unchanged: pull_request trigger only, read-only contents: read permission, default ${{ github.token }}, quoted eligible_branches, and NEXT_RELEASE_ACTION_DIAGNOSTIC: "true".

  • Verified via the upstream PR description that the new SHA was produced by the vp check, vp test --run, and vp pack verification steps.

Pullfrog  | ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@IMax153 IMax153 changed the title Test release queue action inputs Pin fixed next release action Aug 4, 2026
@IMax153 IMax153 reopened this Aug 4, 2026
@effect-slopcop effect-slopcop Bot added the bug Something isn't working label Aug 4, 2026

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

This run reviewed the new commit since the prior pullfrog review.

  • Removed the temporary .github/workflows/release-queue-input-diagnostic.yml workflow that was used to exercise the unmerged action fix.
  • Updated the pinned Effect-TS/next-release-action SHA in .github/workflows/release-queue.yml from 73b52b4034f708dbed94db384459ca5ba9437979 to 0901387026995718742a42e0f6bf7743d0d83c2f, which corresponds to the merged upstream PR #3 (Expose the config provider to the action).

Pullfrog  | ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot | View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@IMax153
IMax153 enabled auto-merge (squash) August 4, 2026 13:46
@IMax153
IMax153 merged commit c3c7647 into main Aug 4, 2026
20 checks passed
@IMax153
IMax153 deleted the test/release-queue-inputs branch August 4, 2026 13:47
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
basic.ts 7.06 KB 7.06 KB 0.00 KB (0.00%)
batching.ts 9.86 KB 9.86 KB 0.00 KB (0.00%)
brand.ts 6.34 KB 6.34 KB 0.00 KB (0.00%)
cache.ts 10.62 KB 10.62 KB 0.00 KB (0.00%)
config.ts 20.60 KB 20.60 KB 0.00 KB (0.00%)
differ.ts 20.20 KB 20.20 KB 0.00 KB (0.00%)
http-client.ts 21.49 KB 21.49 KB 0.00 KB (0.00%)
logger.ts 10.76 KB 10.76 KB 0.00 KB (0.00%)
metric.ts 8.98 KB 8.98 KB 0.00 KB (0.00%)
optic.ts 7.18 KB 7.18 KB 0.00 KB (0.00%)
pubsub.ts 14.90 KB 14.90 KB 0.00 KB (0.00%)
queue.ts 11.58 KB 11.58 KB 0.00 KB (0.00%)
schedule.ts 10.74 KB 10.74 KB 0.00 KB (0.00%)
schema-class.ts 19.14 KB 19.14 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 28.96 KB 28.96 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 25.29 KB 25.29 KB 0.00 KB (0.00%)
schema-string-transformation.ts 13.30 KB 13.30 KB 0.00 KB (0.00%)
schema-string.ts 10.94 KB 10.94 KB 0.00 KB (0.00%)
schema-template-literal.ts 15.17 KB 15.17 KB 0.00 KB (0.00%)
schema-toArbitraryLazy.ts 21.94 KB 21.94 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 24.34 KB 24.34 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 19.18 KB 19.18 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 19.01 KB 19.01 KB 0.00 KB (0.00%)
schema-toFormatter.ts 18.87 KB 18.87 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 22.60 KB 22.60 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 19.52 KB 19.52 KB 0.00 KB (0.00%)
schema.ts 18.41 KB 18.41 KB 0.00 KB (0.00%)
stm.ts 12.54 KB 12.54 KB 0.00 KB (0.00%)
stream.ts 9.80 KB 9.80 KB 0.00 KB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant