fix(cluster): use layerProtocolHttpRouter in HttpRunner#5962
Closed
aniravi24 wants to merge 1 commit intoEffect-TS:mainfrom
Closed
fix(cluster): use layerProtocolHttpRouter in HttpRunner#5962aniravi24 wants to merge 1 commit intoEffect-TS:mainfrom
aniravi24 wants to merge 1 commit intoEffect-TS:mainfrom
Conversation
…t-TS#5918 layerHttpOptions and layerWebsocketOptions were using layerProtocolHttp and layerProtocolWebsocket which create their own internal routers via routerTag.Live, ignoring the router from HttpLayerRouter.serve. This caused RPC routes to not be registered on the served router, resulting in 404 errors for inter-runner communication. The fix is to use layerProtocolHttpRouter and layerProtocolWebsocketRouter which properly use the router from context.
🦋 Changeset detectedLatest commit: e3c2f4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
cluster doesn't use HttpLayerRouter as it is an experimental module. In effect 4 this will change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layerHttpOptions and layerWebsocketOptions were using layerProtocolHttp and layerProtocolWebsocket which create their own internal routers via routerTag.Live, ignoring the router from HttpLayerRouter.serve. This caused RPC routes to not be registered on the served router, resulting in 404 errors for inter-runner communication.
The fix is to use layerProtocolHttpRouter and layerProtocolWebsocketRouter which properly use the router from context.
Type
Description
Related