Skip to content

fix(color): progress bar dialog window may be clipped on TX16S Mk3#7378

Open
philmoz wants to merge 1 commit into
mainfrom
philmoz/fix-progress-dialog-size
Open

fix(color): progress bar dialog window may be clipped on TX16S Mk3#7378
philmoz wants to merge 1 commit into
mainfrom
philmoz/fix-progress-dialog-size

Conversation

@philmoz
Copy link
Copy Markdown
Collaborator

@philmoz philmoz commented May 19, 2026

Correctly size progress bar dialog window.

2.12 & 3.0.

Summary by CodeRabbit

  • Style
    • Progress dialog height now aligns with standard application UI element sizing for improved visual consistency.

Review Change Stack

@philmoz philmoz added this to the 2.12.2 milestone May 19, 2026
@philmoz philmoz added bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b262512e-81fd-4448-b10a-8d7c8c6ac7de

📥 Commits

Reviewing files that changed from the base of the PR and between 00d7544 and d0770c0.

📒 Files selected for processing (1)
  • radio/src/gui/colorlcd/libui/dialog.cpp

📝 Walkthrough

Walkthrough

The PR updates ProgressDialog to use the centralized EdgeTxStyles::UI_ELEMENT_HEIGHT constant for its Progress widget height instead of a hardcoded value of 32, aligning the dialog with the design system.

Changes

Progress Dialog Styling

Layer / File(s) Summary
Progress dialog height styling
radio/src/gui/colorlcd/libui/dialog.cpp
ProgressDialog constructor now creates its Progress widget using EdgeTxStyles::UI_ELEMENT_HEIGHT instead of a hardcoded 32 for consistency with design system constants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks the required 'Fixes #' issue reference and provides minimal detail about the changes. Add the issue number (e.g., 'Fixes #7378') and provide more detailed explanation of the problem and solution.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the specific issue (progress bar dialog clipping on TX16S Mk3) and the fix being applied.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch philmoz/fix-progress-dialog-size

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant