fix(color): add lvgl LV_USE_LARGE_COORD support#7358
Open
3djc wants to merge 1 commit into
Open
Conversation
Member
|
This would be the better approach then, along with some documentation / education that over 1000 files in a single directory (i.e. sounds) will start to impact on performance anywhere where there are file lookups - i.e. opening file picker on colorlcd, and presumably has some impact on SD logging also (there is a easy fix for that with lua - organise / manage by year / model, etc - LogManager - is one example of managing this. That is, if we can't have a subtle prompt in the UI about this (as opposed to a blocking popup every time) ;) |
Collaborator
Author
|
Not only that, but simply playing the file using SF does require parsing the FAT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tackling #7343 in a different way than #7346, allowing large coordinates. The only downside of this approach is that it don't let users know that they are doing something wrong by storing way to many files in a single directory that has impact in FAT32, but the fix is programming wise a better fix.
@philmoz validated this approach
Fixes #7343
This is an alternative to #7346