Skip to content

fix(color): add lvgl LV_USE_LARGE_COORD support#7358

Open
3djc wants to merge 1 commit into
mainfrom
3djc/lvgl-large-coords
Open

fix(color): add lvgl LV_USE_LARGE_COORD support#7358
3djc wants to merge 1 commit into
mainfrom
3djc/lvgl-large-coords

Conversation

@3djc
Copy link
Copy Markdown
Collaborator

@3djc 3djc commented May 10, 2026

This is tackling #7343 in a different way than #7346, allowing large coordinates. The only downside of this approach is that it don't let users know that they are doing something wrong by storing way to many files in a single directory that has impact in FAT32, but the fix is programming wise a better fix.

@philmoz validated this approach

Fixes #7343

This is an alternative to #7346

@3djc 3djc added bug 🪲 Something isn't working backport/2.12 To be backported to a 2.12 release also. labels May 10, 2026
@3djc 3djc changed the title fix: add lvgl LV_USE_LARGE_COORD support fix(color): add lvgl LV_USE_LARGE_COORD support May 10, 2026
@pfeerick
Copy link
Copy Markdown
Member

pfeerick commented May 10, 2026

This would be the better approach then, along with some documentation / education that over 1000 files in a single directory (i.e. sounds) will start to impact on performance anywhere where there are file lookups - i.e. opening file picker on colorlcd, and presumably has some impact on SD logging also (there is a easy fix for that with lua - organise / manage by year / model, etc - LogManager - is one example of managing this. That is, if we can't have a subtle prompt in the UI about this (as opposed to a blocking popup every time) ;)

@pfeerick pfeerick added this to the 2.12.2 milestone May 10, 2026
@3djc
Copy link
Copy Markdown
Collaborator Author

3djc commented May 11, 2026

Not only that, but simply playing the file using SF does require parsing the FAT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/2.12 To be backported to a 2.12 release also. bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: for file list popups, handle too many files occurance better

2 participants