chore(radio): update French 🇫🇷 translations#7345
Conversation
Per translations provided by @Pat6874 in #7339 (comment)
pfeerick
added
translation
backport/2.12
pfeerick
changed the title
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@radio/src/translations/i18n/fr.h`:
- Around line 34-35: Update the French quick-menu string literals to proper
French with accents: change TR_QM_MANAGE_MODELS value from "Gerer\nModels" to
"Gérer\nModèles" and TR_QM_MODEL_SETUP from "Modeles\nSetup" to
"Modèles\nConfiguration" (or "Installation" if preferred); also find and replace
the remaining English words in the other quick-menu defines (the ones using
"Settings", "Functions", and "A propos") so they read in French with correct
accents (e.g., "Paramètres" for Settings, "Fonctions" for Functions, and "À
propos" for A propos) to ensure consistent localization.
- Line 86: Update the French translation to use the accented "Écran" instead of
"Ecran": replace the string value for the macro TR_MAIN_VIEW_X ("Ecran ") with
"Écran " and also fix the other occurrence of "Ecran" noted at the later
occurrence (line 1426) so all instances use the accented form consistently.
- Line 1429: The label TR_OPEN_QUICK_MENU uses a past/state phrasing ("Ouvert.
Menu Rapide"); change it to an imperative action for a shortcut label by
updating the string macro TR_OPEN_QUICK_MENU to an imperative French phrase such
as "Ouvrir le menu rapide" (or equivalent concise imperative), so the shortcut
reads as an action rather than a state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fe60c17f-8efb-4d99-abba-ca258b49ed7b
📒 Files selected for processing (1)
radio/src/translations/i18n/fr.h
| #define TR_QM_MANAGE_MODELS "Gerer\nModels" | ||
| #define TR_QM_MODEL_SETUP "Modeles\nSetup" |
There was a problem hiding this comment.
Complete French localization in the updated quick-menu labels
Lines 34, 35, 39, 51, and 54 still contain English terms (Models, Setup, Settings, Functions) and missing accents (Gerer, Modeles, A propos). This weakens FR consistency in a translation-focused PR.
💬 Suggested wording update
-#define TR_QM_MANAGE_MODELS "Gerer\nModels"
-#define TR_QM_MODEL_SETUP "Modeles\nSetup"
+#define TR_QM_MANAGE_MODELS "Gérer\nModèles"
+#define TR_QM_MODEL_SETUP "Modèles\nConfig."
-#define TR_QM_MODEL_SETTINGS "Modeles\nSettings"
+#define TR_QM_MODEL_SETTINGS "Modèles\nRéglages"
-#define TR_QM_GLOB_FUNC "Globales\nFunctions"
+#define TR_QM_GLOB_FUNC "Fonctions\nglobales"
-#define TR_QM_ABOUT "A propos\nEdgeTX"
+#define TR_QM_ABOUT "À propos\nEdgeTX"Also applies to: 39-39, 51-51, 54-54
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@radio/src/translations/i18n/fr.h` around lines 34 - 35, Update the French
quick-menu string literals to proper French with accents: change
TR_QM_MANAGE_MODELS value from "Gerer\nModels" to "Gérer\nModèles" and
TR_QM_MODEL_SETUP from "Modeles\nSetup" to "Modèles\nConfiguration" (or
"Installation" if preferred); also find and replace the remaining English words
in the other quick-menu defines (the ones using "Settings", "Functions", and "A
propos") so they read in French with correct accents (e.g., "Paramètres" for
Settings, "Fonctions" for Functions, and "À propos" for A propos) to ensure
consistent localization.
| #define TR_MAIN_MENU_ABOUT_EDGETX "A Propos EdgeTX" | ||
| #define TR_MAIN_VIEW_X "Screen " | ||
| #define TR_MAIN_MENU_THEMES "THÈMES" | ||
| #define TR_MAIN_VIEW_X "Ecran " |
There was a problem hiding this comment.
Use accented spelling for “Écran” consistently
Line 86 and Line 1426 use Ecran instead of Écran, while the file already uses accented forms elsewhere.
✏️ Suggested fix
-#define TR_MAIN_VIEW_X "Ecran "
+#define TR_MAIN_VIEW_X "Écran "
-#define TR_CURRENT_SCREEN "Ecran actuel"
+#define TR_CURRENT_SCREEN "Écran actuel"Also applies to: 1426-1426
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@radio/src/translations/i18n/fr.h` at line 86, Update the French translation
to use the accented "Écran" instead of "Ecran": replace the string value for the
macro TR_MAIN_VIEW_X ("Ecran ") with "Écran " and also fix the other occurrence
of "Ecran" noted at the later occurrence (line 1426) so all instances use the
accented form consistently.
| #define TR_CURRENT_SCREEN "Ecran actuel" | ||
| #define TR_SHORT_PRESS "Appui court" | ||
| #define TR_LONG_PRESS "Appui long" | ||
| #define TR_OPEN_QUICK_MENU "Ouvert. Menu Rapide" |
There was a problem hiding this comment.
Prefer imperative wording for shortcut action labels
Line 1429 ("Ouvert. Menu Rapide") reads like a state, not an action. For a key shortcut label, an imperative verb is clearer.
✏️ Suggested fix
-#define TR_OPEN_QUICK_MENU "Ouvert. Menu Rapide"
+#define TR_OPEN_QUICK_MENU "Ouvrir menu rapide"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #define TR_OPEN_QUICK_MENU "Ouvert. Menu Rapide" | |
| `#define` TR_OPEN_QUICK_MENU "Ouvrir menu rapide" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@radio/src/translations/i18n/fr.h` at line 1429, The label TR_OPEN_QUICK_MENU
uses a past/state phrasing ("Ouvert. Menu Rapide"); change it to an imperative
action for a shortcut label by updating the string macro TR_OPEN_QUICK_MENU to
an imperative French phrase such as "Ouvrir le menu rapide" (or equivalent
concise imperative), so the shortcut reads as an action rather than a state.
There was a problem hiding this comment.
@pfeerick, you're right — apologies for the formatting error. Here's the corrected suggestion:
-#define TR_OPEN_QUICK_MENU "Ouvert. Menu Rapide"
+#define TR_OPEN_QUICK_MENU "Ouvrir menu rapide"There was a problem hiding this comment.
@coderabbitai Suggestion incorrectly has backticks around the define.
There was a problem hiding this comment.
@pfeerick, you're absolutely right — apologies for the repeated formatting error. Here is the correct suggestion:
-#define TR_OPEN_QUICK_MENU "Ouvert. Menu Rapide"
+#define TR_OPEN_QUICK_MENU "Ouvrir menu rapide"( ˶°ㅁ°) !!
|
@3djc Since you know french (I hope! 😆) can you look at the coderabbit suggestions and tell it / me which ones you agree with ;) |
1 participant
Per translations provided by @Pat6874 in #7339 (comment)
Summary by CodeRabbit