fix(color): play startup 'hello' audio before Lua widgets

[philmoz]

Changes:

• Ensure 'hello' audio is played first.
• Remove STORAGE_MODELSLIST define (equivalent to COLORLCD).
• Cleanup view layout management code.

Note: issue #135 also mentions SF/GF audio may play before the 'hello' audio; but this is not reproducible in recent versions.

Fixes #135

Marked for 3.0; but could be applied to 2.12 if desired.

[pfeerick]

Hm...

Remove STORAGE_MODELSLIST define (equivalent to COLORLCD).

You've made this equivalent to COLORLCD here though, haven't you... as it is not actually equivalent. When STORAGE_MODELSLIST was implemented, it was originally done in a way that was not tied to the colour UI, leaving the possibility in the future that the B&W UI might also get labels functionality also in the future.

Although this has not eventuated (yet?), I'm just concerned here about the collapsing of a specific feature flag into a more generic and non-descriptive one.

[philmoz]

You've made this equivalent to COLORLCD here though, haven't you... as it is not actually equivalent. When STORAGE_MODELSLIST was implemented, it was originally done in a way that was not tied to the colour UI, leaving the possibility in the future that the B&W UI might also get labels functionality also in the future.

Although this has not eventuated (yet?), I'm just concerned here about the collapsing of a specific feature flag into a more generic and non-descriptive one.

Ok, I will revert this change. Although I can't see B&W getting labels as the UI would be unworkable on the small screen.

[pfeerick]

Note: issue #135 also mentions SF/GF audio may play before the 'hello' audio; but this is not reproducible in recent versions.

And unfortunately I didn't link to the discord message that time, otherwise would have been able to fully double check the requirements to trigger that. Given it was from around 2.5/2.6 though, I think we can safely safe enough stuff has changed since then that it probably is gone.

Seems to be working great on T15 - hello.wav, yappu, ls triggered SF playtrack vs former yappu, hello.wav, ls triggered SF playtrack. 🚀 And I think given the age of this issue, it should be in 2.12... it's one our earlier ones given the issue number! ;)