Dc6 buddybackup

[bbrungardt02]

No description provided.

[pfeerick]

For whatever reason, the "Install" steps of the workflow tests (which simply runs yarn --immutable) are failing at

  ➤ YN0018: │ @electron/node-gyp@https://github.com/electron/node-gyp.git#commit=06b29aafb7708acef8b3669835c8a7857ebc92d2: The remote archive doesn't match the expected checksum

[codecov]

Codecov Report

Attention: Patch coverage is 52.62582% with 1732 lines in your changes missing coverage. Please review.

Project coverage is 49.15%. Comparing base (e9c6197) to head (68effd8).

Files with missing lines	Patch %	Lines
src/shared/backend/services/sdcardJobs.ts	2.36%	578 Missing ⚠️
src/shared/backend/graph/sdcard/index.ts	31.11%	425 Missing ⚠️
...c/renderer/pages/sdcard/editor/tabs/RestoreTab.tsx	41.56%	200 Missing and 1 partial ⚠️
...rc/renderer/pages/sdcard/editor/tabs/BackupTab.tsx	50.64%	153 Missing and 1 partial ⚠️
...rc/renderer/pages/sdcard/editor/tabs/AssetsTab.tsx	67.64%	121 Missing ⚠️
...enderer/pages/sdcard/editor/tabs/ThemesListTab.tsx	62.92%	66 Missing ⚠️
...enderer/pages/sdcard/editor/tabs/ModelsListTab.tsx	72.41%	64 Missing ⚠️
src/renderer/pages/sdcard/SdcardEditor.tsx	76.62%	45 Missing and 9 partials ⚠️
...erer/pages/sdcard/editor/tabs/RadioSettingsTab.tsx	82.14%	40 Missing ⚠️
src/shared/api/github.ts	64.15%	18 Missing and 1 partial ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   44.39%   49.15%   +4.75%     
==========================================
  Files         108      114       +6     
  Lines       12669    15745    +3076     
  Branches      593      726     +133     
==========================================
+ Hits         5625     7739    +2114     
- Misses       7036     7979     +943     
- Partials        8       27      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[raphaelcoeffic]

Other than this one strange thing with yarn, it looks good to me. Maybe looking at the errors with Firefox would be a good idea, though we don't really support it, as it does not have the required APIs.

[raphaelcoeffic]

This shouldn't be necessary (see here).

[raphaelcoeffic]

@pfeerick would you please give it a test drive?

[pfeerick]

FYI I'm back in the land of the living so will be looking at this soon (usability / functionality testing).

[pfeerick]

Okey dokey... had a quick look at this, and I do like how you integrated this into the SD Card content section... the new models, themes and radio tab look great. Might need a little more TLC/fleshing out down the track, but it's a solid start.

Before I go on any further, should the compiled standalone work properly? As if it should, there seem to be some issues outstanding, but obviously not fair to critique/comment if the focus is still on the web side.

Namely, with this kitchen sink config for the TX16S and latest compiled windows asset:
TX16S_ELRS_Buddy.zip

• I'm only seeing "Other" as what I believe to be the label heading
• Info tab for each model has nothing other than the image for two models when several have images, and I would have expected model names to be shown also
• If I tick of some items on the Models tab, and later change my mind and try to tick "Models" on the Radio page, it gets the count wrong (i.e. tick two models on the models tab, then tick Models on the Radio page, it will say 67/65, and won't stay checked).
• Say I tick all three options - Models, Themes, Radio, and then hit Backup. What am I selecting at the select folder prompt that comes up? Source (if so, why???) or destination folder? And why do I get another "select folder" prompt on pressing "confirm & run backup (which says it is for local backup directory)? Also, it seems to run the "radio backup plan" successfully as I get the toast message for that, but it just sits at a "Generating RADIO backup plan..." screen...

Just food for thought... if I should be testing out the web version I'll look at getting that up and running instead...

[pfeerick]

@bbrungardt02 Just checking for a pulse... as there was no reply to my previous comment...